huboard / huboard-web

GitHub issues made awesome
https://huboard.com
61 stars 26 forks source link

Fixes infinite create board loop #358

Open discorick opened 8 years ago

discorick commented 8 years ago

Fixes the infinite loop and closes #357

Additionally, as the changes required some styling, applied a bit of a facelift to the board create process altogether:

When prompted to create a board (buttons light up on hover): image

When third party access restrictions are present: image

When push bit is missing: image

@rauhryan @dahlbyk What do you think? Improvement ?

discorick commented 7 years ago

Some of the styling is broken for the view after the BEM refactor, going to take another stab at with your improvements in place @rauhryan !

rauhryan commented 7 years ago

Do you have a screenshot?

discorick commented 7 years ago

This one:

image

rauhryan commented 7 years ago

What's wrong with it?

discorick commented 7 years ago

It supposed to be a list of items, the original look is up in my original screenshots ☝️

rauhryan commented 7 years ago

Okie dokie, I changed it cause I thought it looked weird.

Sent from my iPhone

On Sep 20, 2016, at 9:02 PM, discorick notifications@github.com wrote:

It supposed to be a list of items, the original look is up in my original screenshots ☝️

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

discorick commented 7 years ago

Lulz, I thought the red line looked weird. If you are cool with how it is now I am happy to let a design discussion slide around these views to when we overhaul them.

rauhryan commented 7 years ago

I'll leave it to you

Sent from my iPhone

On Sep 21, 2016, at 4:45 PM, discorick notifications@github.com wrote:

Lulz, I thought the red line looked weird. If you are cool with how it is now I am happy to let a design discussion slide around these views to when we overhaul them.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.