Closed rauhryan closed 7 years ago
I am curious if you have a GA goal workflow in mind for abandons, we can infer them currently by any traffic that doesn't meet the goal requirements. Having said that 👍 for more data :D
Not a fan of the big purple buttons ?
Idk based on the current implementation
you'd see
Or some infinity combination of /creating => (retry...abandon)
Not a fan of the big purple buttons ?
It wasn't the design that threw me off, I actually prefered the bigger purple buttons.
The css debt didn't seem worth it, there was a triple specific selector on a 'input.btn.primary' nested under another class
There was also use of forms and form inputs inside anchor tags. They didn't really need to be forms and serve just fine as anchor tags that are styled.
I got carried away fixing the markup that I just simplified it all to use the built in bootstrap styles.
It wasn't the design that threw me off, I actually prefered the bigger purple buttons.
The css debt didn't seem worth it, there was a triple specific selector on a 'input.btn.primary' nested under another class
Not sure I 100% follow - if we prefer a certain styling, why can't we achieve without the debt ? Aren't we optimizing in the opposite direction of where we want to go then?
Relates to #358
I jumped into the comments on #358 and wanted to help out.
I started off by finding a rough closed div tag inside the form tags and started backtracking and folding up all the markup to find out how to fix it. I then needed to add indenting so I'm very sorry for the diff not being very useful.
Things I have address in the PR