search

huboard / huboard-web

GitHub issues made awesome
https://huboard.com
61 stars 26 forks source link

Ember cli upgrade 2.4.3 #383

Closed rauhryan closed 7 years ago

dahlbyk commented 7 years ago

Glad to see you picked up on the failing build.

Let's hold off on PRs for additional ember-cli upgrades until we get this green, merged and deployed to production.

dahlbyk commented 7 years ago

ember-app/.travis.yml

Is this file actually needed?

Eh? (I only ask because it's brand new.)

Other than that I think we're good here.

rauhryan commented 7 years ago

ember-app/.travis.yml

Is this file actually needed? Eh? (I only ask because it's brand new.)

Answer: Ember-cli keeps adding/expecting it to be there. The upgrade process keeps adding from the ember init command.

It's nice to have it there because ember init will give me a diff of what the default travis yml is supposed to look like, which helps to know if there is some change that needs to be ported to our actual travis yml