search

hubot-archive / hubot-auth

Assign roles to users and restrict command access in other scripts
149 stars 54 forks source link

Allow referring to self in the first-person for add/remove role commands #15

Closed therealklanni closed 9 years ago

therealklanni commented 9 years ago

Quite simply, allow "I" to refer to the user just like we do in the "what roles" command.

patcon commented 9 years ago

+1 looks good! Any chance you could copy-paste a test case to cover this?

therealklanni commented 9 years ago

Sure, np

patcon commented 9 years ago

Hm. Not sure what happened, but went from working after your first commit, to broken after you added the tests, so something happened:

Clearly, something is up with the way the tests are hooked up on travis, as it didn't fail out :/

It might have to do with your regex in line 90 where you added a new matching group when I don't think you needed to? Just looked briefly though

therealklanni commented 9 years ago

Are you certain? The tests passed locally even. I will take another look.

On Tue, Feb 3, 2015, 6:35 PM Patrick Connolly notifications@github.com wrote:

Hm. Not sure what happened, but went from working after your first commit, to broken after you added the tests, so something happened:

Clearly, something is up with the way the tests are hooked up on travis, as it didn't fail out :/

It might have to do with your regex in line 90 where you added a new matching group when I don't think you needed to? Just looked briefly though

— Reply to this email directly or view it on GitHub https://github.com/hubot-scripts/hubot-auth/pull/15#issuecomment-72773904 .

therealklanni commented 9 years ago

screen shot 2015-02-03 at 11 20 42 pm

Not sure what to say.

patcon commented 9 years ago

Yeah, odd. I had the same error locally, and started to investigate, but it was really weird. Like something was sticking around between tests somehow :/

Gimme a day or two to dig in, and if not, I'll just merge I suppose

patcon commented 9 years ago

Actually, it looks like it's just junk output, but it's not actually failing. I'll just merge :)

patcon commented 9 years ago

Tagged and releases in v1.2.0

therealklanni commented 9 years ago

Weird. Thanks!