search

hubot-archive / hubot-auth

Assign roles to users and restrict command access in other scripts
149 stars 54 forks source link

Don't add `admin` to roles array (and in particular, don't add multiple) #3

Closed patcon closed 10 years ago

patcon commented 10 years ago

Right now, it seems that the last commit (related to the displayRoles var) made it so that now admin is added to the actual user object in the users hash. And since this wasn't expected behaviour of the person who made the change, there's no checking for doubles, so it adds a new array item every time a roles command is run.

patcon commented 10 years ago

ping @technicalpickles

And can you give me merge access on this? (I was the one who transferred it to you a few days ago :)

parkr commented 10 years ago

:+1:

patcon commented 10 years ago

@technicalpickles bump? If I did this the wrong way, please feel free to just transfer the repo back to me so that I can maintain it

technicalpickles commented 10 years ago

@patcon I was away on vacation. You should have access now.

patcon commented 10 years ago

Ah, no! Didn't mean to heckle. Good job with the vacay. Eventually someone will build a Github autoresponder :)

patcon commented 10 years ago

Ah, no! Didn't mean to heckle. Good job with the vacay. Eventually someone will build a Github autoresponder :)