search

hubot-archive / hubot-auth

Assign roles to users and restrict command access in other scripts
149 stars 54 forks source link

Added username support in HUBOT_AUTH_ADMIN var #49

Closed sebastiandero closed 7 years ago

sebastiandero commented 7 years ago

Check the issue description for more information, this adds username support to hubot auth admin env_var

sebastiandero commented 7 years ago

Issue: #48

cecilia-sanare commented 7 years ago

Hey @sebastiandero.

Unfortunately the reason this functionality has never been implemented in the past was due to the ability to fake usernames in some (if not all) of the clients supported by hubot.

This means that usernames aren't a secure way of ensuring that the user making a request is indeed an admin.

sebastiandero commented 7 years ago

@ceci-woodward I see, maybe a 'Hubot get my id' command would be nice, I have had to implement this in my script since in slack there is no other way for a user to get their ID

cecilia-sanare commented 7 years ago

@sebastiandero Yeah, the only other way I know of to get your id is via the slack api or logging it in the console which is a bit of a pain.

If you have the time, feel free to modify this PR to add a whats my id? command and I'll look it over.

sebastiandero commented 7 years ago

@ceci-woodward will do this week!