search

hubot-archive / hubot-auth

Assign roles to users and restrict command access in other scripts
149 stars 54 forks source link

General cleanup #5

Closed patcon closed 10 years ago

patcon commented 10 years ago

Added a config hash to remove all the envvars from logic. Compacted some code for clarity.

The non-whitespace diff https://github.com/hubot-scripts/hubot-auth/compare/v1.0.0...general-cleanup?w=1

Taking the set-as-anything approach for envvars from hubot-irc https://github.com/nandub/hubot-irc#irc-server-fake-ssl

cc: @Mawalu

mawalu commented 10 years ago

Good job. +1

patcon commented 10 years ago

Merged. Thanks so much for the contribution @Mawalu!

patcon commented 10 years ago

Oh hey, mind if I give you push access? I like to work according to this philosophy :) http://felixge.de/2013/03/11/the-pull-request-hack.html

patcon commented 10 years ago

Heh well anyhow, you have push access :)

I just ask that if you ever feel like submitting again, we should both agree to go through pull requests. Anyhow, thanks again!

mawalu commented 10 years ago

Wow thanks. Also thanks for the link. Never heard about that before.