search

hubot-archive / hubot-auth

Assign roles to users and restrict command access in other scripts
149 stars 54 forks source link

Command: what is my name? whats my name? what's my name? #50

Closed sebastiandero closed 7 years ago

sebastiandero commented 7 years ago

Hey, finished a whats my name command that supports quite generous variations!

sebastiandero commented 7 years ago

@ceci-woodward Hey, have a look at the code, tell me if it needs improvement

sebastiandero commented 7 years ago

Added a whats my id command aswell

cecilia-sanare commented 7 years ago

@sebastiandero Sorry it took so long.

I actually reviewed this 19 days ago, however I didn't realize GitHub makes you submit all the changes and then submit the entire review separately.

sebastiandero commented 7 years ago

@ceci-woodward Hey, sure, i can do some tests, never unit tested hubot before lets see how it goes

sebastiandero commented 7 years ago

@ceci-woodward do i understand correctly? test user alice has an id "alice" right?

sebastiandero commented 7 years ago

@ceci-woodward could you take a look if the testing is thorough enough?

sebastiandero commented 7 years ago

No problem!

cecilia-sanare commented 7 years ago

@sebastiandero Your changes should be present in hubot-auth@2.1.0!

Thanks for contributing!

sebastiandero commented 7 years ago

@ceci-woodward my pleasure!