search

hubot-archive / hubot-github-repo-event-notifier

Notifies about any GitHub repo event available via webhook.
https://www.npmjs.org/package/hubot-github-repo-event-notifier
57 stars 42 forks source link

Include pmgarman's improvements #19

Closed martinb3 closed 10 years ago

martinb3 commented 10 years ago

Submitting this for @pmgarman as his improvements make this script much nicer.

patcon commented 10 years ago

Nice! I do really like that this adds support for everything else, but it does make pull requests notifications much noisier: From the service hook creation page, they appear to notify for "opened, closed, assigned, labeled, or synchronized", which might be too much for active projects.

Would it be cool to go back to the original buildNewIssueOrPRMessage callback for pull requests, at least until we've got more fine-grained control of notifications voiced? (https://github.com/gratipay/hubot-github-repo-event-notifier/issues/9)

cc: @parkr

patcon commented 10 years ago

Also @whit537, can you re-add me as an admin on this repo so that I can manage this, or maybe transfer it to the "hubot-scripts" organization?

martinb3 commented 10 years ago

Sweet! Don't we get fine grained control by what events are chosen for the webhook in the GH interface? I feel like right now, we're whitelisting it twice (once in Github, once on the bot). FWIW, I'd love to see the bot support all of those additional events (it seems worse to have it say, "got a " than just be silent if it doesn't recognize an event).

Nevermind, I see what you mean. This isn't actually PR'd off my repo, so I can't fix it. I'll fix it in #20.

patcon commented 10 years ago

@martinb3 Thanks for the quick response! (Did you mean to close the issue?)

Github webhooks allow you to select by event type (issues, pull requests, releases, etc), but via the github UI, you can't choose which actions for that type :)

We were previously filtering by the "opened" action for issues and PR's. Again, current active projects might get quite a bit more noisy with this change. In particular Gittip and Jekyll repos, if someone is doing queue maintenance and tagging PR's or something.

In the interest of not surprising users, it would be awesome to use the old function for now

martinb3 commented 10 years ago

I understand what you mean now. I closed it, and opened a new one in #20. I'll add the feature to filter event type and action, and push to #20 :).

chadwhitacre commented 10 years ago

Also @whit537, can you re-add me as an admin on this repo so that I can manage this, or maybe transfer it to the "hubot-scripts" organization?

I tried transferring to hubot-scripts but failed because I don't have admin perms there. We have four other hubot- repos that it would be good to hand off as well, no? I've configured a hubot-stuff team under the Gratipay org with admin perms on these five repos:

https://github.com/gratipay/hubot-seen https://github.com/gratipay/hubot-github-repo-event-notifier https://github.com/gratipay/hubot-freshdesk-ticket-notifier https://github.com/gratipay/hubot-pagerduty-github https://github.com/gratipay/hubot-heroku-deploy-notifier

You're on that team, so does that unblock you here @patcon?

patcon commented 10 years ago

Yep! I've got admin perms on the hubot-scripts org, so thanks!