search

hubot-archive / hubot-google-images

A hubot script that interacts with the Google Images API
126 stars 66 forks source link

Animated results are hit or miss #13

Closed HaroldPutman closed 9 years ago

HaroldPutman commented 9 years ago

If you say animate me kittens you might not get an actual animation. Google image search API does not seem to provide an equivalent to the "experimental" imgtype=animated neither in the deprecated image search API nor the Custom Search Engine API. The current makeshift approach is to tack "animated" on to the query.

A better approach would be to use the giphy API. or some other reliable source of animated GIF's.

mhemmings commented 9 years ago

animate never works for me now. Always returns jpg or png :(

soehlert commented 9 years ago

I also never get animations anymore at all.

vwbusguy commented 9 years ago

Same here - there's no more apparent .gif filtering

welkerc commented 9 years ago

I am seeing maybe 1 in 100 being gifs.

HaroldPutman commented 9 years ago

Fix is coming in PR #14

soehlert commented 9 years ago

I don't see this as a fix. I can get giphy working as an integration in slack already and it's horrible compared to google was.

ETA: I don't mean this to come off as rude either, sorry if it seems so. I just don't think using giphy should be the answer for this. I hope investigation of using google image search is on going, unfortunately I don't have the skills to supply the work.

HaroldPutman commented 9 years ago

I understand. Google has a way of doing this but they don't expose it in the public API. Unfortunately the feature we were using before was "experimental" and they dropped it. After we have it consistently showing animated Gif's let's open a new ticket saying the gifs are not any good. ;-)

soehlert commented 9 years ago

Fair enough. Thanks Harold.