search

hubot-archive / hubot-google-images

A hubot script that interacts with the Google Images API
126 stars 66 forks source link

Added an option to use own mustachify #6

Closed louim closed 9 years ago

louim commented 9 years ago

Since the real mustachify seems to always be under heavy load, I added an option to pass your own mustache url if you deploy your own mustachify. It also include the fixes made in #5 (since they affect the same lines and I didn't think to start clean before doing the second PR.

afeld commented 9 years ago

Tangentially, I would love some uptime help :grimacing: https://github.com/afeld/mustachio/issues/44

technicalpickles commented 9 years ago

This looks like a good addition :+1:

I think some documentation is in order though. You can add a Configuration section in src/google-images.coffee, as well as mentioning it in the README.md along with linking to https://github.com/afeld/mustachio

louim commented 9 years ago

@technicalpickles I some documentation as requested, let me know if anything else is needed.

louim commented 9 years ago

@technicalpickles Thanks, it's fixed now. Coffeescript is really awesome. I should do more.

technicalpickles commented 9 years ago

There was a merge conflict from https://github.com/hubot-scripts/hubot-google-images/pull/3 . I tried to merge it myself, but having problems pushing it.

If you can resolve the conflict, I should be able to merge and add you as a collaborator.

louim commented 9 years ago

@technicalpickles I see you beat me to it! :smile:

technicalpickles commented 9 years ago

I worked out my push issue, and released it as 0.2.0

Also added you as a collaborator as promised. I'll just need your npm login to let you do releases.

Some notes and advice: continue to use PRs even with commit access, so you can get extra :eyes: and feedback. Don't leave code unreleased for long. Use semantic versioning for releasing. You can release with grunt release:<patch|minor|major>. And don't forget this is a default script included with hubot :grin: Hit me up if you have any questions, and you can also use the @hubot-scripts/hubot-google-images team

louim commented 9 years ago

@technicalpickles it is the same that I use here: louim. Thanks for adding me!

technicalpickles commented 9 years ago

@louim done!