search

hubot-archive / hubot-pager-me

PagerDuty integration for Hubot
https://www.npmjs.com/package/hubot-pager-me
MIT License
73 stars 93 forks source link

Let's convert the script from CoffeeScript to JavaScript #216

Closed KeesCBakker closed 5 months ago

KeesCBakker commented 1 year ago

Hi, I would love to contribute to the script, but coffee is something I drink, not code. Can we convert the code to JavaScript?

stephenyeargin commented 1 year ago

I think that would be a good move, particularly with the plan to drop CoffeeScript support. This one, like hubot-grafana, is a fairly important one for incident response, so lets tread carefully. It also has a pattern where parts of it are abstracted away from the responders, so it may be easier to test in isolation compared to it all being in a single file.

KeesCBakker commented 1 year ago

This this project might benefit from some API mock testing as well, but they are currently not in place.

KeesCBakker commented 10 months ago

Any plans on releasing?

stephenyeargin commented 10 months ago

Done.

https://github.com/hubot-archive/hubot-pager-me/releases/tag/v4.0.0

I really need to get some of these wired up with a GitHub action that will do it for me rather than running it from my own command line.

joeyguerra commented 10 months ago

@stephenyeargin Hubot uses semantic-release for it's releases

stephenyeargin commented 5 months ago

Fixed by #217