search

hubot-archive / hubot-pager-me

PagerDuty integration for Hubot
https://www.npmjs.com/package/hubot-pager-me
MIT License
73 stars 92 forks source link

Slack adapter and 'pager me as ...' #29

Closed stephenyeargin closed 9 years ago

stephenyeargin commented 9 years ago

I think there may be a compatability issue with the Slack adapter. Oddly, it appears to allow a !pager ack command to go through (with the same warning) but not to append notes.

Stephen> !pager me as stephen@example.com
Hubot> Okay, I'll remember your PagerDuty email is <mailto:stephen@example.com|stephen@example.com>
Stephen> !pager note 74075 Already fixed in PR #2136
Hubot> Sorry, I expected to get 1 user back for <mailto:stephen@example.com|stephen@example.com>, but got 0 😓. Can you make sure that is actually a real user on PagerDuty?
stephenyeargin commented 9 years ago

Dupe #24

stephenyeargin commented 9 years ago

So I will call this still an ongoing issue, but I'm still not certain it should attempt to be fixed here or upstream. I updated to use 3.2.1 of the Slack adapter (which includes the patch referenced) and it seems to still be adding some bonus content to the brain store.

Ref: https://github.com/slackhq/hubot-slack/pull/125 (merged)

Reported as well in https://github.com/slackhq/hubot-slack/pull/152 if this is strictly an issue with the Slack adapter.

stephenyeargin commented 9 years ago

They released the updated adapter today. For anyone who comes across this issue, ensure you are running at least "hubot-slack": "3.3.0",.