search

hubot-archive / hubot-pager-me

PagerDuty integration for Hubot
https://www.npmjs.com/package/hubot-pager-me
MIT License
73 stars 93 forks source link

Allow smart quotes in who's on call command #45

Closed kashizui closed 9 years ago

kashizui commented 9 years ago

Mac users (on the Hubot-Slack integration at least) often have trouble with the "who's on call" command, since the default OS X settings will convert quotation marks into angled quotation marks: “” and ‘’ .

This change simply recognizes the angled single quote that automatically gets rendered when Mac users type out the command:

hubot who’s on call

alexlo03 commented 9 years ago

:+1:

stephenyeargin commented 9 years ago

There is setting to disable this in most Mac applications by clicking in the text field and going to Substitutions > Smart Quotes, but I'd agree that is super annoying. :+1:

screen shot 2015-09-01 at 5 53 25 pm

kashizui commented 9 years ago

Yep, the main problem is people learning to use the command for the first time, or those who are just unwilling to turn off the setting.

They can always choose to use hubot who is on call, but that isn't currently the default syntax listed in the help docs. On Tue, Sep 1, 2015 at 6:54 PM Stephen Yeargin notifications@github.com wrote:

There is setting to disable this in most Mac applications by clicking in the text field and going to Substitutions > Smart Quotes, but I'd agree that is super annoying. [image: :+1:]

[image: screen shot 2015-09-01 at 5 53 25 pm] https://cloud.githubusercontent.com/assets/80459/9619130/6c80c0ac-50d2-11e5-966c-b0bce760b900.png

— Reply to this email directly or view it on GitHub https://github.com/hubot-scripts/hubot-pager-me/pull/45#issuecomment-136885428 .

stephenyeargin commented 9 years ago

Fixed in v2.1.5

kashizui commented 9 years ago

Thanks for the super fast response!