search

hubot-archive / hubot-pager-me

PagerDuty integration for Hubot
https://www.npmjs.com/package/hubot-pager-me
MIT License
73 stars 92 forks source link

Fix ack and ack! commands #56

Closed codywilbourn closed 9 years ago

codywilbourn commented 9 years ago

Typo in acknowledged was causing validation error and command would not complete. Looks like a change in validation on Pagerduty's side.

Request response was 

{"error":
  {"message":"Invalid Input Provided",
   "code":2001,
   "errors":["Status must be a list of triggered, acknowledged, or resolved."]
}}

Fixes #57

stephenyeargin commented 9 years ago

Heh. That appears to have come with the original commit (725f20712172bfd350f2f2ff67dd6470976d044c). :+1:

stephenyeargin commented 9 years ago

So my only question is if this fix will rock anybody's world that depended on it not working for the last few years?

codywilbourn commented 9 years ago

Luckily I had a pager just come through and could test this. With the proposed change any currently ack'd incidents will be re-ack'd, which might be okay behavior for pager ack, as you'll re-up your incident response timer before it goes back to triggered. For the ack! case, you would steal acknowledged tickets, and that might rock some worlds.

stephenyeargin commented 9 years ago

Released in v2.1.7

technicalpickles commented 9 years ago

For the ack! case, you would steal acknowledged tickets, and that might rock some worlds.

That wasn't the intended use for ack!. It should only ack things that are triggered.