search

hubot-archive / hubot-pager-me

PagerDuty integration for Hubot
https://www.npmjs.com/package/hubot-pager-me
MIT License
73 stars 93 forks source link

pager schedule $SCHEDULE no longer returns anything #64

Closed TheFynx closed 8 years ago

TheFynx commented 8 years ago

With 2.18, you can no longer return a specific schedule, merge 63 refactored most of this functionality, I think there's still a rogue reference to the oneScheduleMatching variable that was changed in the aforementioned merge.

stephenyeargin commented 8 years ago

/cc @mmrobins

aaronblythe commented 8 years ago

:+1: Looks good.

stephenyeargin commented 8 years ago

Fixed via #65

mmrobins commented 8 years ago

was gonna look tonight, but glad @TheFynx got a fix in so quick, thx. It's hard to modify code without tests like this.

TheFynx commented 8 years ago

@mmrobins well, I may have not fixed it completely. I'll continue testing, but seems some of the stuff doesn't like hipchat. who's on call for has issues and it won't return schedule in hipchat (too many adapters...). I'll do some more testing and open up another issue.