search

hubot-archive / hubot-pager-me

PagerDuty integration for Hubot
https://www.npmjs.com/package/hubot-pager-me
MIT License
73 stars 93 forks source link

who's on call will return a block rather than individual mesages #79

Closed kaesackett closed 8 years ago

kaesackett commented 8 years ago

The "who's on call" functionality intermittently works when the return payload is particularly large - sometimes returning only partial results, sometimes working perfectly, and sometimes returning nothing at all.

This PR address the issue of who's on call sending each returned item as an individual message by waiting for all results to be received and then concatenating them together. As an aside, it seems to fix the intermittent nature of the functionality due to hanging async requests, as described in https://github.com/hubot-scripts/hubot-pager-me/issues/43.

stephenyeargin commented 8 years ago

:+1:

stephenyeargin commented 8 years ago

Released in v2.1.13