Closed mcg closed 6 years ago
/cc #101 , because it caused issues.
Hi, just giving this issue a bump. Is there any interest in upgrading to use the PagerDuty v2 REST API.
The deadline has been pushed out as follows:
I'm no longer working for a group with a PD account, but I would be happy to review code and offer advice.
@jbaldo Hi , Ive just converted my Hubot to use PagerDuty v2 rest API , it kind of works but having some issues and errors getting pager schedules, this could be related to a change of subdomains and switch to enterpirse only SSO login but Im not sure
@pcoorie awesome! do you have a PR somewhere? @stephenyeargin if you start a trial account and need and need an extension to review, I can help with that.
@jbaldo a Problem Record? No, I can reproduce it though and grab the errors if that helps?
Sorry, no. I meant a pull request in GitHub so that we can review and collaborate.
Hi @jbaldo and @stephenyeargin https://github.com/pcoorie/hubot-v1/pull/1/files
I appreciate any input you may have, the main branch works under v1 Pagerduty API, the APIv2 branch doesnt not work, I keep seeing this error below when running under APIv2
at PagerDutyError.Error (native)
at new PagerDutyError (/Users/pcoorie/hubot-test/wdc-hubot/src/pagerduty.coffee:10:1, <js>:26:51)
at /Users/pcoorie/hubot-test/wdc-hubot/src/pagerduty.coffee:44:20, <js>:74:16
at IncomingMessage.<anonymous> (/Users/pcoorie/hubot-test/wdc-hubot/node_modules/scoped-http-client/src/index.js:95:22)
at emitNone (events.js:91:20)
at IncomingMessage.emit (events.js:185:7)
at endReadableNT (_stream_readable.js:974:12)
at _combinedTickCallback (internal/process/next_tick.js:74:11)
at process._tickCallback (internal/process/next_tick.js:98:9)
[Mon Apr 16 2018 11:43:38 GMT+1000 (AEST)] ERROR TypeError: Cannot read property 'entries' of null
at /Users/pcoorie/hubot-test/wdc-hubot/src/scripts/pagerduty.coffee:815:7, <js>:921:17
at /Users/pcoorie/hubot-test/wdc-hubot/src/pagerduty.coffee:46:9, <js>:76:16
at IncomingMessage.<anonymous> (/Users/pcoorie/hubot-test/wdc-hubot/node_modules/scoped-http-client/src/index.js:95:22)
at emitNone (events.js:91:20)
at IncomingMessage.emit (events.js:185:7)
at endReadableNT (_stream_readable.js:974:12)
at _combinedTickCallback (internal/process/next_tick.js:74:11)
at process._tickCallback (internal/process/next_tick.js:98:9)
I have set up sandbox free Slack and PagerDuty (trail) accounts for testing. This Hubot connects to these.
The Slack account is https://goulburn.slack.com
the PagerDuty domain is https://coorie-cloud.pagerduty.com
@jbaldo and @stephenyeargin I can give you both PD and Slack sandbox accounts for this env if that will help ?
@pcoorie I'll take a look at your PR next week probably, I'd like to help get this across the finish line soon-ish.
Doesn't look like you can create V1 API tokens anymore - any word on if v2 support will be landing at some point?
@mwarkentin I've been working on this off and on, still has a bit to go unfortunately.
@silverp1 thanks for the update - is there a PR we should keep an eye on or just monitor this issue for updates?
@mwarkentin I'll open up a PR once I have something reasonable, things are mostly broken at the moment so it doesn't seem worth while.
https://github.com/hubot-scripts/hubot-pager-me/pull/111
Updated: We've tested it today and looks like everything works as expected.
up?
@biggless Added some notes on the PR. I apologize that this has taking so long after you've put so much effort into getting it going.
Calling this one finished with v3.0.0
.
https://github.com/hubot-scripts/hubot-pager-me/releases/tag/v3.0.0
Looks like the v1 API will be going away July 6, 2017(https://v2.developer.pagerduty.com/v2/docs/api-v2-frequently-asked-questions). Any hope that for v2 support before then?