search

hubot-archive / hubot-seen

A hubot script that tracks when/where users were last seen.
https://www.npmjs.org/package/hubot-seen
24 stars 15 forks source link

Default to showing relative times #15

Closed strugee closed 7 years ago

strugee commented 7 years ago

So I went to fix #14 and it turns out this is already present in the codebase. However, I still think that way is much more useful, so I switched the default and documented how to get the old behavior back.

Obviously this is semver-major, but since #12 hasn't happened yet it doesn't really matter.

patcon commented 7 years ago

Thanks! I like the idea of changing the default, but thoughts on just defaulting timeago to "true", and requiring it to be set falsey to disable? "timeago" is a common keyword for this behaviour in my understanding :)

strugee commented 7 years ago

@patcon sure! I didn't know "timeago" was a common keyword but if that's the case, keeping it makes a lot more sense to me

strugee commented 7 years ago

@patcon rebased on top of master and pushed a fix. I couldn't make it so that any falsy value will be accepted (because every environment variable is automatically a string) but setting it to false will work.