search

hubot-archive / hubot-tell

Hubot plugin to send a user a message the next time they are present in the room
MIT License
26 stars 15 forks source link

Room seems to be incorrect for hubot-slack adapter #7

Closed parkr closed 6 years ago

parkr commented 8 years ago

I ran into an issue today after #2 was merged. hubot-slack doesn't appear to have the same behaviour as HipChat and therefore fails.

Per my comment in https://github.com/hubot-scripts/hubot-tell/pull/2#issuecomment-165899139:

The reply_to value overrides the room name. The reply_to seems to encode both the room and the user sending the message so it changes per user. When the enter hook is triggered, it looks up the room name with no reply_to, which would, of course look different. So the flow is:

  1. Receive a message in #devops that matches regexp for telling.
  2. Extract reply_to (C02EKKBLG) and username (parkr)
  3. Save message to localstorage["C02EKKBLG"]["parkr"].
  4. Later, parkr enters #devops. Receive EnterMessage with room devops and username parkr.
  5. Look up localstorate["devops"]["parkr"], but nothing is there.

Not sure whether this is a bug in hubot-slack or in hubot-tell.

parkr commented 8 years ago

@lorenzhs, I posted an issue with hubot-slack to see if they know what's going on. Might be able to dig into this a bit later.