search

hubotio / generator-hubot

Hubot generator for Yeoman
MIT License
156 stars 83 forks source link

Use hubot's name in shell adapter #32

Closed mal closed 9 years ago

mal commented 9 years ago

It feels weird to name the bot during setup and then have it called Hubot regardless in local testing. So lets not do that anymore :smile_cat:

technicalpickles commented 9 years ago

Good point. I suspect this came over from original generator, that only used the name for a directory to create, and didn't actually have templates.

technicalpickles commented 9 years ago

The name does get used in the Procfile. I guess both wouldn't hurt, but if Procfile is just calling bin, I think we can just remove it from bin.

technicalpickles commented 9 years ago

I think we can just remove it from bin.

Actually, I mean I think we can remove it from Procfile, as it just calls bin/hubot itself, which would have the name.

technicalpickles commented 9 years ago

I was curious what would happen if you called bin/hubot --name someothername, since that would under the hood call node_modules\.bin\hubot.cmd --name originalbotname --name someothername, and it seems to correctly use only the last specified name.

mal commented 9 years ago

Yup, tried that myself, useful for when you're generating examples and you want the bot to represent itself as the generic hubot.

technicalpickles commented 9 years ago

Released in v0.2.5, thanks!