search

hubotio / generator-hubot

Hubot generator for Yeoman
MIT License
155 stars 91 forks source link

cleaned up checking of availability of adapter on npm #66

Closed richardharrington closed 8 years ago

richardharrington commented 8 years ago
  1. Removed what seemed like an extraneous console.log statement.
  2. Changed variable name from 'available' to 'unavailable', to match both the npm-name api, and what the generator-hubot code is actually doing. Only the name of the variable was off, and was causing confusion.
technicalpickles commented 8 years ago

Good catch!

The log was mostly for debugging. If we need to debug it at some point, we can figure out how to add explicit debug logging when doing so.

I was cribbing the availbility code from somewhere I can't remember, so available must have come from there.

technicalpickles commented 8 years ago

I just remembered. It was from yeoman's generator for generators. I think it's sinced changed to use something different though: https://github.com/yeoman/generator-generator/blob/master/app/index.js#L4