search

hubotio / generator-hubot

Hubot generator for Yeoman
MIT License
155 stars 91 forks source link

Update Node engine specified in package.json #77

Closed gilesvangruisen closed 7 years ago

gilesvangruisen commented 7 years ago

Hi there! Thanks for this package :)

See here for a bit more context on this PR.

This updates the template package.json to specify a more recent version of Node, one which supports ES6 by default. I'm writing a bot that uses ES6 scripts so I noticed this issue when I tried to deploy to Heroku. Everything ran fine on my laptop, because I have a recent version of Node which supports ES6, but Heroku was using the version specified in package.json, which doesn't support ES6 by default.

This isn't a permanent solution, because it will become out-of-date again before too long, but I hope this helps. Please let me know if you have any questions.

gilesvangruisen commented 7 years ago

@gr2m didn't see this until now. Yes that works, excited to see how that progresses

mose commented 7 years ago

In the while, we got "node": "> 4.0.0" and travis config was updated too. This PR is not relevant anymore.