search

hubotio / generator-hubot

Hubot generator for Yeoman
MIT License
155 stars 91 forks source link

Fix js version to test with Travis CI #81

Closed 178inaba closed 7 years ago

178inaba commented 7 years ago

Since version 0.10 does not have Promise, hubot-test-helper can not be used.

Travis CI log:

...
$ npm test
...
  1) foobar responds to hello:
     ReferenceError: Promise is not defined
      at Room.receive (node_modules/hubot-test-helper/lib/index.js:79:18)
      at Object.Room.user.say (node_modules/hubot-test-helper/lib/index.js:62:26)
      at Context.<anonymous> (test/foobar-test.coffee:21:29)
  2) foobar hears orly:
     ReferenceError: Promise is not defined
      at Room.receive (node_modules/hubot-test-helper/lib/index.js:79:18)
      at Object.Room.user.say (node_modules/hubot-test-helper/lib/index.js:62:26)
      at Context.<anonymous> (test/foobar-test.coffee:27:29)
...

Remove version 0.10. Add version the latest node and 6, 5, 4.

stephenyeargin commented 7 years ago

Ran into this today. Would be good for the defaults to reflect the LTS support of Node.

bkeepers commented 7 years ago

Thanks!