search

hubotio / generator-hubot

Hubot generator for Yeoman
MIT License
155 stars 91 forks source link

Use .gitignore from github/gitignore #96

Closed strugee closed 7 years ago

strugee commented 7 years ago

See https://github.com/github/gitignore/blob/master/Node.gitignore.

strugee commented 7 years ago

@gr2m I disagree - I think there's almost never (literally never?) a situation where you'd want to check in e.g. coverage data. If someone chooses to later add coverage to their bootstrapped project, it'll already be in .gitignore for them, and they won't run the risk of forgetting to add it. Plus while I generally strongly agree with

The best code is the code you don’t add 👍

I feel like it doesn't really apply here because this isn't "code" and isn't actively making the codebase more complex?

That being said if you feel strongly about it I can amend this patch to cut out irrelevant things. There are still a lot of things in the patched file that are useful, like ignoring npm/yarn logs and such.

gr2m commented 7 years ago

@gr2m I disagree - I think there's almost never (literally never?) a situation where you'd want to check in e.g. coverage data

I’m sorry @strugee I think there was a misunderstanding. I agree that you’d never want to commit coverage data. The point I wanted to make is to not add rules for things that don’t apply (yet).

I can amend this patch to cut out irrelevant things

That would be great 👍 thanks a lot

mose commented 7 years ago

Honestly I rather think that the generated gitignore can include things that are generic the same way github creates generic gitignores.

I would rather just be in favor to merge that pull request as is.

strugee commented 7 years ago

Honestly I rather think that the generated gitignore can include things that are generic the same way github creates generic gitignores.

This was my original thinking. Should I still amend the patch? Thanks for the ping by the way ;)

gr2m commented 7 years ago

I really don’t have strong opinions, if @mose prefers it that way, go ahead and merge :) I would prefer to remove the parts that are not relevant to the project, but won’t object merging 👍

mose commented 7 years ago

Cool! let's move on :+1:

hubotbot commented 6 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: