Allow Redis UNIX domain sockets

hubotio / hubot-redis-brain

A hubot script to persist hubot's brain using redis

69 stars 55 forks source link

Allow Redis UNIX domain sockets #1

Closed aw closed 9 years ago

aw commented 9 years ago

The older version of the redis module didn't support UNIX domain sockets.

It appears authentication was already present, but the README didn't mention a colon was required before the password.

aw commented 9 years ago

:sparkles: :+1: :question:

aw commented 9 years ago

Also note, I added REDIS_URL support for redis://passwd@192.168.0.1:16379?prefix as well, but maintained the old notation for backwards compatibility.

technicalpickles commented 9 years ago

So, I can definitely appreciate re-using the existing environment variable instead of adding more variables, but something about export REDIS_URL=redis://:password@/var/run/redis.sock?prefix doesn't feel awesome :sweat:

aw commented 9 years ago

@technicalpickles Agreed, and thanks for the suggestions. I'll push the improvements in the next few days.

aw commented 9 years ago

Sorry, I don't have time to work on this now so I'll re-open/fix this PR when I do. Thanks!