search

hubotio / hubot-redis-brain

A hubot script to persist hubot's brain using redis
69 stars 55 forks source link

Basic Cloud Foundry Support #2

Closed explody closed 7 years ago

explody commented 9 years ago

Fairly self explanatory - lets the bot fetch redis info from a CF app environment and build a Redis URL from that.

The only part I'm not sure about is line 34:

cfredis = cfenv.getAppEnv(name='p-redis')

Because I don't know if 'p-redis' is always the service name. It's an easy fix if that comes up.

technicalpickles commented 9 years ago

I'm a little uneasy about including an extra dependency that you have to install outside of the script. The benefit of moving to packages per script was to avoid having to document installing scripts. On the other hand, it would seem weird to have that dependency only if you aren't using cloud foundry. In the long run, I'd like to see us move more towards https://github.com/github/hubot/issues/858 so you could have your hubot pull things into its environment, and the script only cares about the environment. I'm not sure where that leaves us for now though.

stale[bot] commented 7 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mose commented 7 years ago

I agree with @technicalpickles especially as this need can be addressed by setting a REDIS_URL. Let's close this PR.