search

hubotio / hubot-redis-brain

A hubot script to persist hubot's brain using redis
69 stars 55 forks source link

Adding basic CloudFoundry support #24

Closed quickjp2 closed 6 years ago

quickjp2 commented 7 years ago

I wanted to be able to use CloudFoundry variables, so I wrote a function to be able to parse through a cf environment to gather the needed parameters for the redis service.

I have tested this script and validated it to work in a running cf instance.

quickjp2 commented 7 years ago

@technicalpickles would you have some time soon to review this?

Thank you!

technicalpickles commented 7 years ago

I'm on paternity leave through the New Year https://github.com/github/hubot/issues/1210

quickjp2 commented 7 years ago

Totally didn't see that, my bad. Congrats and no rush!

quickjp2 commented 7 years ago

@technicalpickles Hope you've had a good leave and subsequent months! Wanted to check in and see what the verdict was about this PR, since I have a few more teams at my company wanting to deploy their own hubot in CloudFoundry. 😃

Thanks!

stale[bot] commented 7 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mose commented 7 years ago

hmm, I'm afraid the recent move from coffeescript to pure js included some code changes that make this pull request impossible to merge as-is.

quickjp2 commented 6 years ago

@mose It's all good, this was submitted way before the move. If you want, you can close this PR, and I'll submit the changes in pure js in a different PR.