search

hubotio / hubot

A customizable life embetterment robot.
https://hubotio.github.io/hubot/
MIT License
16.64k stars 3.75k forks source link

chore(package): bump async to version 3 #1613

Closed joeyguerra closed 1 year ago

joeyguerra commented 1 year ago

Intent

1605 Update dependencies to the latest versions

Approach

The tests were timing out when updating async to v3.2.4. After investigating, the problem was that the async.detectSeries callback was not executing unless message.done was set to true in a Hubot Listener.

This SO question and answer lead me to the issue.

joeyguerra commented 1 year ago

@xurizaemon @levenleven @technicalpickles what do ya'll think about this PR?

joeyguerra commented 1 year ago

It feels so wrong to me to git push --force.

xurizaemon commented 1 year ago

Heh :) yeah it smells bad, but it's better than the alternatives of a new PR for each change, or incorrect history entries, so it's the least bad correct action?

I think force pushing is fine when you're confident that nobody is basing their work off what you've pushed. If you think they are, then force pushing is also fine when appropriately communicated or agreed. (If someone's based work off a branch like this, IMO there's a responsibility on them to mop up if the PR is updated.)

As with sudo, it's the right tool for certain jobs, even though we discourage habitually using it.