search

hubotio / hubot

A customizable life embetterment robot.
https://hubotio.github.io/hubot/
MIT License
16.64k stars 3.75k forks source link

chore(package): Updating and removing dependencies #1617

Closed joeyguerra closed 1 year ago

joeyguerra commented 1 year ago

I removed chalk since it was only used to make some text bold in the Shell Adapter. I don't think bolding was worth including all the chalk dependency surface area.

I also added tests for the Shell adapter since this touches that file.

1605

technicalpickles commented 1 year ago

I don't think bolding was worth including all the chalk dependency surface area.

The main reason for bold text is to make the shell more usable, because otherwise the text looks the same. I could see a case for choosing more than just bold.

Moving the adapter to its own repo could be another possibility.

joeyguerra commented 1 year ago

I think there's value in keeping the Shell in here and the default adapter so that I can use it right off the bat. But I'd rather have less dependencies the bold text for a scenario that is probably short term. As in I'm only using the default Shell adapter for a few minutes before wanting to either build my own, or use a different adapter.

joeyguerra commented 1 year ago

Btw, I was thinking that after merging this request, we could do another release. And then move onto updating the log module.

technicalpickles commented 1 year ago

But I'd rather have less dependencies the bold text for a scenario that is probably short term. As in I'm only using the default Shell adapter for a few minutes before wanting to either build my own, or use a different adapter.

For what it is worth, I've always used the shell adapter when building out scripts initially, so it wasn't ever a 'short term' thing.

If you want to drop the dependency, I can understand that. I'd recommend coding our own bold then, it's just a matter of outputting the right escape codes, and then resetting them after. You could even look at the chalk implementation.

joeyguerra commented 1 year ago

If you want to drop the dependency, I can understand that. I'd recommend coding our own bold then, it's just a matter of outputting the right escape codes, and then resetting them after. You could even look at the chalk implementation.

Done.

technicalpickles commented 1 year ago

Btw, I was thinking that after merging this request, we could do another release. And then move onto updating the log module.

Could you make an issue to track that? Just don't want to lose track. We should get semantic-release going too

joeyguerra commented 1 year ago

Yes. #1620