hubotio / hubot

A customizable life embetterment robot.
https://hubotio.github.io/hubot/
MIT License
16.64k stars 3.75k forks source link

feat(log): Replace log module with the pino module #1618

Closed joeyguerra closed 1 year ago

joeyguerra commented 1 year ago

@levenleven suggested replacing log with pino. So here's a PR so we can test it, compare to log and discuss.

1616 #1492

technicalpickles commented 1 year ago

Is log deprecated? I didn't see it on the list on https://github.com/hubotio/hubot/issues/1605

joeyguerra commented 1 year ago

I didn't see a deprecation warning, but it's been a while since someone made a commit to the repo: https://github.com/medikoo/log.

I created separate a separate PR for updating log because it's a significant change. So I'm treating it as part of a feature release, separate from this upcoming one with just updating dependencies.

This particular PR (using Pino instead) is just to serve as a place to discuss either continue using the log module, or replace it with Pino so that we can have structured logging.

joeyguerra commented 1 year ago

@technicalpickles @xurizaemon @levenleven Ok ya'll. This PR replaces the logging module with Pino which has structured/ndjson logging output. Please review.

Note that I believe this is a major version bump. Let me know if you think otherwise.

joh6nn commented 1 year ago

I would agree that this is a major bump

joeyguerra commented 1 year ago

Just needs someone to approve.

joeyguerra commented 1 year ago

@xurizaemon do you have a few minutes to review this PR?

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 4.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: