search

hubotio / hubot

A customizable life embetterment robot.
https://hubotio.github.io/hubot/
MIT License
16.64k stars 3.75k forks source link

Can I be an owner on the Hubotio org? So that I can also set CI/CD env. variables? #1623

Closed joeyguerra closed 1 year ago

joeyguerra commented 1 year ago

I'm not an owner of the Hubotio org, so I can't set the NPM_TOKEN or any CI/CD env variables. Since we're the only ones responding to issues, I can help more if I was an owner.

joeyguerra commented 1 year ago

@technicalpickles what are you thoughts on making me an owner for the Hubotio org?

xurizaemon commented 1 year ago

👋🏼 also here - I think it will be helpful to debug those things if we can have access to manage settings.

joeyguerra commented 1 year ago

Yeah. That's exactly what I was thinking. The build was failing for Node.js 14.x and when I removed that version from the strategy matrix, the PR was unmergable because the "check" was still required. I don't know why. But I was unable to check settings and troubleshoot. I was lucky to stumble upon a procedure to get the build to work with 14.x.

Alas, luck (hope) is not a strategy. And since we're now the only ones actively supporting development, it would make sense that we have the permissions to troubleshoot everything.

joh6nn commented 1 year ago

I agree it makes sense for you both to be owners now. I probably don't need it at this point in time since I'm way less hands-on at the moment than either of you (which has been impressive and fun to watch!), and if that changes in the future, with you both as owners it's something that's easily fixed

technicalpickles commented 1 year ago

Sorry it took me a bit to get to this. I've changed @xurizaemon and @joeyguerra's role to "Owner". Can y'all verify you can access make changes to those secrets?

joeyguerra commented 1 year ago

@technicalpickles I'm still just a member of the org. I can't see any of the advanced settings.

Just a point of clarification. I need to be an owner of the Hubotio org if I'm going to be able to maintain the repos.

technicalpickles commented 1 year ago

I suspect that entitlements are managing owners as well. I can work on getting that through with someone at GitHub, but you know how long it took last time. This may be a little harder of a sell, but not positive.

In the mean time, are there any ways to work around that? Like, if it is a matter of environment variables, it will be tedious, but can update each repo that needs them.

We could also try setting sync time to pair on it. I can't really commit to being super responsive (as you can probably figure from observations).

joeyguerra commented 1 year ago

It's more about getting the PRs reviewed and approved so I can merge them. I'd also like to define a roadmap and keep updating the codebase to use ES6 import, .mjs file extensions, async/await message sending, and convert the tests to use Node.js Test Runner in order to reduce dependencies. I know you're pretty busy and no one else is responding so I figured if I was an owner, I could run with modernizing the codebase and coming up with a roadmap to evolve Hubot.

Pair programming would be awesome. I'll follow your lead on that since I think you're more time constrained than I am. I'm in the US Central time zone.

technicalpickles commented 1 year ago

It's more about getting the PRs reviewed and approved so I can merge them.

If that's the case, that sounds more like needing to be a maintainer on all the repos. Let's try this...

I've updated @hubotio/new-maintainers since y'all have been added as members of the org, so hopefully you will not be removed. I've added all the org repos to the team as admins:

CleanShot 2023-05-31 at 14 26 11 CleanShot 2023-05-31 at 14 26 07

joeyguerra commented 1 year ago

Thanks @technicalpickles . I was able to merge the hubot-rules PR.

xurizaemon commented 1 year ago

I think we can close this now.