search

hubotio / hubot

A customizable life embetterment robot.
https://hubotio.github.io/hubot/
MIT License
16.64k stars 3.75k forks source link

feat: Use organization scoped adapters like @hubot-friends/hubot-slack #1655

Closed joeyguerra closed 1 year ago

joeyguerra commented 1 year ago

BREAKING CHANGE: This change now requires you to include hubot- when specifying hubot adapters.

fixes #1654

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 7.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

KeesCBakker commented 1 year ago

Hi, I see that you reference "@hubot-friends/hubot-slack". What is that?

(I'm looking for a new Slack adapter that uses Bolt instead of the RTM API)

KeesCBakker commented 1 year ago

Found it! Awesome!! https://www.npmjs.com/package/@hubot-friends/hubot-slack

joeyguerra commented 1 year ago

Yes, that's the one I'm referring to. Please note that it's a fork of the old hubot-slack adapter and EXTENSIVELY modified to utilize @slack/web-api and @slack/socket-mode, replacing Slacks RTM client from @slack/client.

It doesn't use Bolt.

I would love your critical feedback if you use it though.

KeesCBakker commented 1 year ago

At Wehkamp we have a jump-start project for Hubot / Slack chat bots. We have a public base here: https://github.com/wehkamp/bot-zero

With some internal bots we try to add dialog features to the bot, for which we might need bolt (but I'm not sure if I fully understand the difference between socket mode and bolt, as Slack muddies the communication a bit).

The main things we don't want to loose are hubot-grafana and hubot-pager-me, so we're really happy that you came up with something that works with a modern Slack app. Super kudos!

KeesCBakker commented 1 year ago

@joeyguerra looks like we might need to add support to hubot-grafana for the special adapterName as well: https://github.com/stephenyeargin/hubot-grafana/issues/156

KeesCBakker commented 1 year ago

@joeyguerra can you check https://github.com/hubot-friends/hubot-slack/pull/21 for better error handling? I think if we have that in the package we get a better handle on what's going wrong if the Slack API does not want to eat our request.

joeyguerra commented 1 year ago

@KeesCBakker yes. Will collaborate more over there.