hubsif / kodi-magentasport

UNMAINTAINED, see README! Kodi Addon for watching streams from magentasport.de (formerly telekomsport.de) (easyCredit BBL, DEL, 3.Liga, Frauen-Fussball-Bundesliga, Sky Kompakt and more)

GNU General Public License v2.0

19 stars 9 forks source link

No video works anymore #39

Closed MRLB closed 3 years ago

MRLB commented 3 years ago

Unfortunately no video works anymore. Is it possible to check it?

hubsif commented 3 years ago

Please have a look at #38, which has recently been opened. I'll merge and create new releases soon.

MRLB commented 3 years ago

There is also a change in the authorization :-(

uhafner commented 3 years ago

38 helps for free streams. But payed streams seem to require a different handling now.

betacentauri commented 3 years ago

I don’t use this plugin. I have an own for enigma2 boxes. There now playback works again with this change. As already written to MRLB it might be that also the heartbeat URL is not working anymore. I don’t use the heartbeat URL. It’s not necessary to call it.

If you want to take a look at my code: https://github.com/E2OpenPlugins/e2openplugin-TelekomSport/blob/master/plugin/plugin.py#L886

hubsif commented 3 years ago

Hi! Unfortunetaly, I don't have a paid account anymore (perhaps someone can share theirs for testing? 😬 🤐), so I'm actually not able to test this :-( . If it's related to the heartbeat url, I think the log might reveal more. Can someone please share?

uhafner commented 3 years ago

Here is a log:

kodi.log.zip

I started a video without pay option
I started a video with pay option

The version I am using is v2.1.2-beta Kodi 19 (Python 3) (with the patch of #38).

If that does not help, I can share credentials (via Email) for a test.

betacentauri commented 3 years ago

Most likely the heartbeat URL: https://github.com/hubsif/kodi-magentasport/blob/master/default.py#L89

Please try to comment out lines 257-266 (https://github.com/hubsif/kodi-magentasport/blob/master/default.py#L257-L266) Just put a # in front of the lines As said calling the heartbeat URL is not necessary.

uhafner commented 3 years ago

Please try to comment out lines 257-266 (https://github.com/hubsif/kodi-magentasport/blob/master/default.py#L257-L266) Just put a # in front of the lines As said calling the heartbeat URL is not necessary.

Yes, that worked (at least for a non live event)! Thanks!

MRLB commented 3 years ago

and also for live events :-) Thank you 👍

uhafner commented 3 years ago

Hmm, it would make sense to close this issue only when the patch is also part of the repository.

MRLB commented 3 years ago

you are right

hubsif commented 3 years ago

Hi! So, I just created a release with the heartbeat query removed. It might have been required when I first added it, or I wanted the plugin to behave as close as possible like the app does to avoid conflicts. Please test.

uhafner commented 3 years ago

I can confirm, the latest beta version (for Kodi 19) works again! Thanks! 🎉 🎉 🎉