search

hubspot-net / HubSpot.NET

C# .NET Wrapper around the common HubSpot APIs.
MIT License
112 stars 137 forks source link

Remove HubSpot.NET.Core.ReflectionExtensions #38

Open Psypher9 opened 5 years ago

Psypher9 commented 5 years ago

The ReflectionExtensions class does not have any references outside of it self. Since v1 will be changing the serialization strategy/methodology entirely, these might not be needed at all.

Thoughts?

clarkd commented 5 years ago

Seems to make sense to me - although might be worth holding off until we've figured out #37 and how we'll be supporting custom models going forwards, as that might use some of the reflection code?

Psypher9 commented 5 years ago

Well, I tracked down all of the references and there currently aren't any and all of these extensions were previously used in the now deprecated RequestSerializer and RequestDataConverter.

clarkd commented 5 years ago

@Psypher9 I just meant that we might still need some of that code given that the custom models don't work properly right now? Happy to remove if it's still unused after we've figured that out!