dotnet core support - Githubissues

hubspot-net / HubSpot.NET

C# .NET Wrapper around the common HubSpot APIs.

MIT License

112 stars 137 forks source link

dotnet core support #56

Closed EvgenyKhaliper closed 4 years ago

EvgenyKhaliper commented 4 years ago

Hi, any plans on making this package dotnet core friendly ?

warning NU1701: Package 'SquaredUp.HubSpot.NET 0.6.17' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.2'. This package may not be fully compatible with your project.

Psypher9 commented 4 years ago

Yes! Actually, our v1-preview branch is currently in a PR to master. That branch is on the .NET Standard. We will update our package feeds once everything looks good to go.

cfluke-twilio commented 4 years ago

@Psypher9 Hey, I saw this was merged into master. Do you know when it will get published into Nuget?

Thanks for the hard work.

Psypher9 commented 4 years ago

@cfluke-twilio, thanks for checking in!

It'll probably be a few weeks honestly. We've got quite a bit of testing to make sure things are still working. We would really appreciate the help if you would like to help us test what we have so far.

The working changes for the 1.0 release are pretty huge. I would be more than happy to entertain any issues you find.

EvgenyKhaliper commented 4 years ago

Thanks @Psypher9 !!! Will test the basics next week.