search

hubverse-org / example-complex-forecast-hub

An example of a forecast hub with a complex set of modeling tasks
Creative Commons Zero v1.0 Universal
0 stars 2 forks source link

combine target data #19

Closed elray1 closed 8 months ago

elray1 commented 9 months ago

avoid separate target data files per output type group

elray1 commented 8 months ago

This pull request does 2 things:

  1. Add examples with an output_type of "cdf". Resolves issue #13
  2. Create a single, unified data file with target values. It's unclear whether this is where we are really headed with target values long term, but this is an improvement over what's in the repository now.

The submission validations are failing for three reasons: (1) we are modifying existing files, (2) we are submitting outside of the time range corresponding to the forecast rounds specified in the file names, and (3) there is a bug in hubValidations checks related to increasing order of probabilities at cdf evaluation points. I've filed an issue on hubValidations for the third of these, and the first two are expected given that we're creating post hoc examples.

The example still needs to be documented, but I'd propose to merge this in and go back and add documentation later on, see issue #9.