hubverse-org / example-complex-forecast-hub

An example of a forecast hub with a complex set of modeling tasks
Creative Commons Zero v1.0 Universal
0 stars 2 forks source link

add sample output_type example data #8

Closed elray1 closed 6 months ago

elray1 commented 10 months ago

would be nice to have output_type = "sample" in the model output files. Perhaps we can set this up to have trajectories for one model and samples that are not trajectories for another model?

Involves the following tasks:

elray1 commented 8 months ago

I have a question about logistics for how to do this. We have pretty well scoped out what the format of samples will be in this thread, but support for samples does not yet exist in the hubverse schemas or hubValidations. Does it make sense to:

  1. Be bold! Go ahead with setup of samples in the schema and model outputs
  2. Act, but with caution. Do 1, but on a branch of this repository. Hold off on merging in until there is support for samples in core hubverse packages.
  3. Wait until hubverse functionality exists. It won't be long anyways.

One deciding factor might be whether we want to prioritize getting these samples into a data set in hubExamples, or if they might be helpful to have in place when developing other hubverse functionality.

annakrystalli commented 7 months ago

I feel after the schema, working on some example data is the next important step to pushing functionality forward.

I think working in a branch initially is probably sensible but I don't feel we'll need to wait for full functionality to release it.

annakrystalli commented 7 months ago

FYI I have the schema implemented as WIP (as I am testing some downstream implications before settling) here: https://github.com/Infectious-Disease-Modeling-Hubs/schemas/pull/72

elray1 commented 6 months ago

There are two relevant scripts that could be updated to create model output data and target data:

There is an example of how to create samples independently for each target location/week here.

I think it would be nice to have a couple of examples of samples for models with one or two different compound forecast units that they're targeting: