hubverse-org / hubAdmin

Utilities for administering hubverse Infectious Disease Modeling Hubs
https://hubverse-org.github.io/hubAdmin/
Other
1 stars 2 forks source link

Validate that task ID accepted values do not include `NA`s #5

Closed annakrystalli closed 2 weeks ago

annakrystalli commented 1 year ago

One thought I just had is that, if a hub is set up with NA as a required and valid value for a task ID, this will cause false negatives when determining complete cases.

Do you think that might be be a reasonable set up for a hub that we need to have guardrails for? (There is a pretty simple fix I can think of for it)

_Originally posted by @annakrystalli in https://github.com/Infectious-Disease-Modeling-Hubs/hubUtils/pull/93#discussion_r1266348989_

annakrystalli commented 1 year ago

I cannot think of a scenario where we would have NA as a required value for a task ID. I almost think we should have a check that prevents that from being in place?

_Originally posted by @nickreich in https://github.com/Infectious-Disease-Modeling-Hubs/hubUtils/pull/93#discussion_r1266765765_