search

hubverse-org / hubDocs

https://hubverse.io
4 stars 5 forks source link

Attempt at fixing issue #115 #122

Closed micokoch closed 4 weeks ago

micokoch commented 1 month ago

Hello, This PR was trying to address issue #115 . As I mentioned in the issue, I used the HubEnsembles manuscript verbiage to explain the model output and maintain consistency. @elray1, @nickreich, @lshandross - could you look at this PR and see if it can be approved / needs changes / needs to be discarded.

As a side note, I'm having issues because my fork keeps falling behind, and some of the new changes are incompatible, and it has been a bit of a nightmare to sync my fork and branches. Thank you!

micokoch commented 1 month ago

Hi @lshandross - thanks for the review. Sorry I made you review a problematic version of sample-output-type. I messed up when I was updating my fork and I didn't even realize I had kept that old version of the file. I just deleted my version and updated it with the current, accepted one - so that should all be fixed. Thanks!

micokoch commented 1 month ago

Hello. I am removing @nickreich as a reviewer, since he reviewed this previously and I made the change he asked for (removing the journal title).