hubverse-org / hubDocs

https://hubverse.io
5 stars 6 forks source link

Modify documentation for tasks.json #69

Closed mzorn-58 closed 3 months ago

mzorn-58 commented 8 months ago

For targets like peak size, this is not related to time points, so there is no horizon or target date. So in the submission file, you should put NA in those columns. But in the tasks.json, you can put either null or NA Currently you could put required = null, optional = null and this will pass the validation (incorrectly). Fix this in validations for tasks.json file (it should not say a tasks.json with both required=null and optional=null passes)

mzorn-58 commented 3 months ago

Does the above mean that 5.5 needs to be updated to remove the last sentence?

LucieContamin commented 3 months ago

@annakrystalli corrects me if I am wrong but we made an update to allow the required = null, optional = null for this kind of target and this will pass the validation. It is the expected behavior

LucieContamin commented 3 months ago

Sorry I miss that issue, I think we can close it now.

mzorn-58 commented 3 months ago

Thanks Lucie, Will close it.