hubverse-org / hubEnsembles

Ensemble methods for combining hub model outputs.
https://hubverse-org.github.io/hubEnsembles/
Other
6 stars 2 forks source link

Add support for the sample model_output_type in hubEnsembles::linear_pool() #101

Open nickreich opened 7 months ago

nickreich commented 7 months ago

Add support for the sample model_output_type in hubEnsembles so that hub administrators and/or individual modelers can run linear pool ensembles on model_output in sample format.

Acceptance criteria:

elray1 commented 7 months ago

We should discuss and combine this issue with #27

elray1 commented 7 months ago

r.e. "warning is thrown if the number of samples available for all prediction units and from all models are not equal" -- is that something that is a part of an ensembling operation? feels like a validation that should happen somewhere else?

nickreich commented 7 months ago

I think if a user passes model output that has varying numbers of samples per prediction unit (maybe excluding 0s?) there should be a warning thrown. It feels like the kind of thing that could be overlooked but could have weird consequences depending on the implementation.