search

hubverse-org / hubEnsembles

Ensemble methods for combining hub model outputs.
https://hubverse-org.github.io/hubEnsembles/
Other
5 stars 1 forks source link

Remove hmisc dependency #102

Closed lshandross closed 3 months ago

lshandross commented 3 months ago

Solves Issue #55

github-actions[bot] commented 3 months ago

🚀 Deployed on https://6618322ffc810d18e6d24b17--hubensembles-pr-previews.netlify.app

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 42.63566% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 66.54%. Comparing base (7e12730) to head (dd86a19). Report is 3 commits behind head on main.

:exclamation: Current head dd86a19 differs from pull request most recent head 0316a2d. Consider uploading reports for the commit 0316a2d to get more accurate results

Files Patch % Lines
R/Hmisc-utils.R 42.18% 74 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #102 +/- ## =========================================== - Coverage 87.83% 66.54% -21.30% =========================================== Files 5 6 +1 Lines 148 275 +127 =========================================== + Hits 130 183 +53 - Misses 18 92 +74 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lshandross commented 3 months ago

@annakrystalli is it ok that the functions from Hmisc aren't getting covered by tests, as they've been tested in the original package?

lshandross commented 3 months ago

Linting issues have been fixed with pull request #105!