Code review from Hugo

[Bisaloo]

As promised a couple of months ago when reviewing the manuscript.

Overall, the codebase seems in great condition to me so I didn't have much changes to propose.

Here is a summary of the minor changes or fixes:

• 1d3c2ad7ddae403d79d2171451093ad0bd42f4dc uses magrittr pipe consistently to avoid taking a dependency on R 4.1. This was previously discussed in https://github.com/hubverse-org/hubUtils/issues/23 but the policy might have evolved after almost 2 years(?). In all cases, it's probably good to ensure consistency in which pipe is used to avoid surprises if used in corner cases. For what it's worth, the tidyverse will start using R 4.1 in about a year from now.

• f04685cadb092867d9124e6a80178f6f79812d94 uses boolean arithmetic to simplify counting FALSEs and avoids comparing a logical to FALSE which can quickly cause headaches :dizzy_face:

  (c(TRUE, FALSE, TRUE) == FALSE)  == c(FALSE, TRUE, FALSE)
  #> [1] TRUE TRUE TRUE

  ^{Created on 2024-07-19 with reprex v2.1.1}

• 921b4892da1c9634ef37bcc3bb0be9d57f95e522 gets purrr to return a (logical) vector directly and removes the need for unlist(). This has the nice added benefit that output type is checked, which can prevent errors when refactoring later.
• d7c08ac0820c3de3dbb7a17dd1f9ace7b3ad8896 is expected to fail R CMD check and motivates the need for the following commit
• df70cf15d4f6ed0aee15cdd872776c52d4590792 fixes the issue highlighted in the previous commit

[lshandross]

@elray1 what do you think about using the magrittr vs base R pipe? Is our stance still the same as on that issue, i.e. the former is preferable to avoid the dependency on R 4.1?

[elray1]

I agree with Hugo's comment -- using the magrittr pipe already felt like a borderline decision a couple of years ago, and i'm good with moving on. (Actually, reading more carefully, maybe I got Hugo's comment backwards. But regardless, I think that at this point I'd vote to standardize on the base R pipe)

[lshandross]

Ok, I can make the changes to update the pipe to the standard one, then merge this pull request