search

hubverse-org / hubEnsembles

Ensemble methods for combining hub model outputs.
https://hubverse-org.github.io/hubEnsembles/
Other
5 stars 2 forks source link

Simple ensemble #4

Closed elray1 closed 1 year ago

nickreich commented 1 year ago

minor suggestion without having looked at the code: to avoid magrittr import, could we just use the base pipe of |>?

elray1 commented 1 year ago

We had discussed the question of which pipe to use in the context of hubUtils, and there we decided to go with the magrittr pipe to avoid a requirement that users be on R version 4.*.

elray1 commented 1 year ago

Noting that current R CMD CHECK failures are due to undocumented parameters -- but those are the parameters that will be passed on to hubUtils::as_model_output_df, and I'm hoping to do something like @inheritParams (or otherwise borrow documentation) for those once that function is available.