search

hubverse-org / hubEnsembles

Ensemble methods for combining hub model outputs.
https://hubverse-org.github.io/hubEnsembles/
Other
5 stars 1 forks source link

remove Hmisc dependency #55

Closed nickreich closed 3 months ago

nickreich commented 5 months ago

Noting that in HubEnsembles there is one fairly simple function that is used in one place from the Hmisc package. I don't know standard procedure here, but I wonder if we could simply reproduce that single function (with attribution) on our own to reduce dependencies on, well, "miscellaneous" R packages that otherwise are not core to the mission of the package.

nickreich commented 5 months ago

@annakrystalli I'm wondering if you have thoughts about R cultural conventions about re-using a small amount of code (with attribution) from one package to avoid dependencies.

annakrystalli commented 5 months ago

Yes very common and acceptable practice. Good to add a comment in the code too about it, see for example: https://github.com/Infectious-Disease-Modeling-Hubs/hubDevs/blob/c566e5b5a60bccccbc9f038be39b529b9b8557a3/R/usethis-utils.R#L1-L12

lshandross commented 5 months ago

This is a package-based issue, not a manuscript one, right? Can someone else confirm before I remove the manuscript label?

nickreich commented 5 months ago

yes, this is an issue based on the package code.