hubverse-org / hubEnsembles

Ensemble methods for combining hub model outputs.
https://hubverse-org.github.io/hubEnsembles/
Other
6 stars 2 forks source link

vignette review part 1 #62

Closed nickreich closed 8 months ago

nickreich commented 8 months ago

This review encompasses comments on sections 1-3 of the paper. basically, before the heavy coding starts. I didn't review the coding part because I wanted to be able to run it and see how it all worked. But I'd encourage review and maybe merging of some or all of this sooner rather than later and then once we sort out the vignette building issues I'd like to review the rest of the vignette.