Closed annakrystalli closed 6 months ago
additionally, standardize indentation amounts (currently there is a mix of 2 spaces, 4 spaces, and 6 spaces)
also: use double quotes consistently, consistency of spacing around operators and specification of function arguments like =
I feel some of the code could be cleaner:
[x] avoid long lines
[ ] avoid pipes within function calls, e.g.
Better to use:
[ ] Loading libraries but then using
hubEnsembles::
in the code. I feel it will look better and still be quite clear to only loaddplyr
(which is used repeatedly throughout and a very familiar package to users) andhubEnsembles
and avoid using::
when calling functions from those packages. All other packages we use::
to clarify where the functions are coming from.As none of these changes actually affect the results, they are just for better style and visual clarity, and to avoid potential merge confilcts with the current open branches, I would be happy to take a look at this once the manuscript is nearly done (and decisions re Infectious-Disease-Modeling-Hubs/hubEnsembles-manuscript#11 & Infectious-Disease-Modeling-Hubs/hubEnsembles-manuscript#12 have been made