vertical axis labels for figures 5.2 and 5.3

hubverse-org / hubEnsemblesManuscript

https://htmlpreview.github.io/?https://github.com/Infectious-Disease-Modeling-Hubs/hubEnsemblesManuscript/blob/master/analysis/paper/hubEnsembles_manuscript.html

Other

1 stars 2 forks source link

vertical axis labels for figures 5.2 and 5.3 #21

Closed elray1 closed 6 months ago

elray1 commented 7 months ago

A few comments related to vertical axis labels for these figures:

It would be nice to consistently use either "average" or "avg". If "average" is preferred but too long, could perhaps use "average\ntarget data"?
can we use the same label for the top two panels in 5.3 that we use in 5.2?
since "mae" already includes "mean", I don't think we need to write "average mae"
for the coverage plots, I suggest using "PI coverage" instead of "average cov95". this is not a very strong opinion though, ok if you don't take it.

lshandross commented 7 months ago

Currently the function code used to generate these figures uses a paste statement to create the y-axis labels, hence "average mae" and "average cov95" in points 3 and 4 above. Does (3) feel important enough to make a change in the code?

elray1 commented 7 months ago

I'm going to defer to a second opinion from someone else (@nickreich?) for this

nickreich commented 6 months ago

I think it'd be good to implement the change @elray1 suggests. If it is going to take >1 hour of re-writing code to change one axis label then it's not worth it, but I do think it's worth putting some effort into fixing if it's relatively easy.

lshandross commented 6 months ago

Definitely won't take that long! Will go implement the fix now