Closed eahowerton closed 7 months ago
I'll also note that rendering the .qmd
file generated a new folder, analysis/paper/hubEnsembles_manuscript_files
with a number of other files which I haven't pushed. Is this something I should include in the repo or should we add it to .gitignore
?
Good point @lshandross - I just pushed the extra files. The HTML preview seems to be working on my end now
Mine too. It looks really good. Two more minor things though before I think it's ready to merge in:
Good point @lshandross. I fixed the places where "figure" was duplicated, and cleaned up a few additional things. I couldn't find any equations that were not displaying, can you list the sections where I should look? Thanks!
The equations under the Mathematical definitions and properties of ensemble methods section don't show up for me in the preview (see below), though it's fine when I open the file locally
Noting it seems the problem with preview is no longer an issue.
Hello @eahowerton and @lshandross , I started to review and make corrections and decided to just go ahead and commit directly to the PR instead of opening another PR. Hope you don't mind (I thought it would be more efficient!)
The main things I fixed:
here()
styler::tidyverse_style()
regularly when making changes to the code in the paper. Must be in the Source editor though, doesn't work in the Visual editor)rrtools
which is much more relevant to a research compendium. Once we have DOIs and publication details for papers/pre-prints etc we can add them. We also need to complete the uthors field in each citations but I've left that for now as wasn't sure what format you wanted. (#26 )Another cool thing included in the README is a button to launch a binder in the cloud where theoretically anyone can interact with the code. It's not currently working and needs a bit of work. In any case, I've opened an issue (#25 ) to revisit it when I have some time.
Combined, this PR:
This is the original groundwork to transition from .Rmd to .qmd for the
hubEnsembles
manuscript. This includes the following changes:hubEnsembles_manuscript.qmd
and removinghubEnsembles_manuscript.Rmd
paper.qmd
that was generated byrrtools
. This includes adding preliminary author information (related to #8). Note, this authorship information needs to be reviewed/updated, and I could not get the authors to show up in the .html file.